Skip to content

Update screenshot UI Tests with new designs - #13082

Merged
JavonDavis merged 10 commits into
developfrom
update/screenshot-ui-tests-with-new-designs
Nov 20, 2020
Merged

Update screenshot UI Tests with new designs#13082
JavonDavis merged 10 commits into
developfrom
update/screenshot-ui-tests-with-new-designs

Conversation

@designsimply

@designsimply designsimply commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Updates the UI Tests that will be used for the screenshots project.

android-phone-1

Challenges

  • Android screenshots are currently broken, there's a PR in progress at Fix/screenshot ui tests #13031, and too get around it temporarily, I created a new branch and then did a git pull origin fix/screenshot-ui-tests to pull in the work from Fix/screenshot ui tests #13031.
  • After I switch to the fix/screenshot-ui-tests branch, I still get one failed test with a wiremock error which I am not sure how to get around (see Fix/screenshot ui tests #13031 (review) for details), but I think updating mocked data will resolve it.
  • I think I have a good draft for what's needed for the tests themselves with a few TODOs left but I am having trouble updating the mocked data and getting that to work so I can get to the screens I need to.

Updated mock data is a blocker at this point and I need help with that part.

To test:

  1. Switch to this branch.
  2. You may also need to pull in the fix/screenshot-ui-tests branch.
  3. Select WPScreensotTest as the run configuration.
  4. Run the test and confirm it passes.
    PR submission checklist:
  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 8, 2020

Copy link
Copy Markdown

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Oct 8, 2020

Copy link
Copy Markdown

You can test the changes on this Pull Request by downloading the APK here.

@JavonDavis

Copy link
Copy Markdown
Contributor

Heads up I branched off of this branch and tested your changes with the mock changes on the update/mocks-for-screenshots branch.

@JavonDavis
JavonDavis merged commit ba06cd9 into develop Nov 20, 2020
@jkmassel
jkmassel deleted the update/screenshot-ui-tests-with-new-designs branch October 17, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants